Re: [PATCH 1/1] clk: socfpga: gate: Fix of by factor 2 for serial console

From: Benedikt Spranger
Date: Thu Oct 05 2023 - 23:39:20 EST


On Thu, 05 Oct 2023 14:03:19 -0700
Stephen Boyd <sboyd@xxxxxxxxxx> wrote:

> What's your analysis?
Commit 9607beb917df ("clk: socfpga: gate: Add a determine_rate hook")
breaks serial console output and changing the determine_rate hook to
__clk_mux_determine_rate() fix the issue.

> Does this patch also fix it?
>
> ---8<---
> diff --git a/drivers/clk/socfpga/clk-gate.c
> b/drivers/clk/socfpga/clk-gate.c index 8dd601bd8538..b3400d2d8128
> 100644 --- a/drivers/clk/socfpga/clk-gate.c
> +++ b/drivers/clk/socfpga/clk-gate.c
> @@ -173,6 +173,7 @@ void __init socfpga_gate_init(struct device_node
> *node) if (init.num_parents < 2) {
> ops->get_parent = NULL;
> ops->set_parent = NULL;
> + ops->determine_rate = NULL;
> }
>
> init.parent_names = parent_name;

No. serial console is broken too.

Regards
Benedikt Spranger