Re: [PATCH net-next v2 5/6] net: cpmac: remove driver to prepare for platform removal

From: Thomas Bogendoerfer
Date: Thu Oct 05 2023 - 15:11:12 EST


On Thu, Oct 05, 2023 at 07:16:34AM -0700, Jakub Kicinski wrote:
> On Thu, 5 Oct 2023 16:08:55 +0200 Thomas Bogendoerfer wrote:
> > On Fri, Sep 22, 2023 at 08:15:26AM +0200, Wolfram Sang wrote:
> > > AR7 is going to be removed from the Kernel, so remove its networking
> > > support in form of the cpmac driver. This allows us to remove the
> > > platform because this driver includes a platform specific header.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> > > Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > > ---
> > > Changes since v1:
> > > * added ack
> > >
> > > MAINTAINERS | 6 -
> > > drivers/net/ethernet/ti/Kconfig | 9 +-
> > > drivers/net/ethernet/ti/Makefile | 1 -
> > > drivers/net/ethernet/ti/cpmac.c | 1251 ------------------------------
> > > 4 files changed, 1 insertion(+), 1266 deletions(-)
> > > delete mode 100644 drivers/net/ethernet/ti/cpmac.c
> > > [..]
> >
> > is it ok for network people to route this patch via mips-next tree
> > or do you want to apply to net-next ?
>
> We have a ".remove callback should return void" conversion from Uwe
> queued for the deleted driver (231ea972ccaf5b). The conflict will be
> really trivial, but I guess no conflict beats trivial conflict so better
> if we take it? :S

makes sense, so I'll just apply the other patches.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]