Re: [PATCH] s390/cio: Fix a memleak in css_alloc_subchannel

[Peter Oberparleiter]

On 21.09.2023 09:14, Dinghao Liu wrote:
> When dma_set_coherent_mask() fails, sch->lock has not been
> freed, which is allocated in css_sch_create_locks(), leading
> to a memleak.
> 
> Fixes: 4520a91a976e ("s390/cio: use dma helpers for setting masks")
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>

-- 
Peter Oberparleiter
Linux on IBM Z Development - IBM Germany R&D