Re: [PATCH v2 next] compiler.h: Move __is_constexpr() to compiler.h.

From: Kees Cook
Date: Thu Oct 05 2023 - 12:30:24 EST


On Thu, Oct 05, 2023 at 11:39:54AM +0000, David Laight wrote:
> Prior to f747e6667ebb2 __is_constexpr() was in its only user minmax.h.
> That commit moved it to const.h - but that file just defines ULL(x) and
> UL(x) so that constants can be defined for .S and .c files.
> So apart from the word 'const' it wasn't really a good location.
> Instead move the definition to compiler.h just before the similar
> is_signed_type() and is_unsigned_type().
> This may not be a good long-term home, but the three definitions
> belong together.
>
> Signed-off-by: David Laight <david.laight@xxxxxxxxxx>

Yeah, this is what I'd expect (a duplicate move in tools/). Thanks!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook