Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2)

From: Mimi Zohar
Date: Thu Oct 05 2023 - 10:36:57 EST


On Thu, 2023-10-05 at 16:22 +0300, Amir Goldstein wrote:
> On Thu, Oct 5, 2023 at 4:14 PM Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
> >
> > On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote:
> > > On Thu, Oct 5, 2023 at 12:59 PM syzbot
> > > <syzbot+b42fe626038981fb7bfa@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > >
> > > > Hello,
> > > >
> > > > syzbot tried to test the proposed patch but the build/boot failed:
> > >
> > > My mistake. Please try again:
> > >
> > > #syz test: https://github.com/amir73il/linux ima-ovl-fix
> >
> > Thanks, Amir. "mutext_init(&iint->mutex); moved, but the status
> > initialization lines 161-166 were dropped. They're needed by IMA-
> > appraisal for signature verification.
> >
> > iint->ima_file_status = INTEGRITY_UNKNOWN;
> > iint->ima_mmap_status = INTEGRITY_UNKNOWN;
> > iint->ima_bprm_status = INTEGRITY_UNKNOWN;
> > iint->ima_read_status = INTEGRITY_UNKNOWN;
> > iint->ima_creds_status = INTEGRITY_UNKNOWN;
> > iint->evm_status = INTEGRITY_UNKNOWN;
> >
>
> They are dropped from iint_init_once()
> They are not needed there because there are now set
> in every iint allocation in iint_init_always()
> instead of being set in iint_free()

I was only looking at the patch and noticed the removal. Thanks, this
looks good.

Mimi