Re: [PATCH v2] KVM: x86/xen: ignore the VCPU_SSHOTTMR_future flag

From: Paul Durrant
Date: Thu Oct 05 2023 - 09:56:27 EST


On 04/10/2023 19:30, Sean Christopherson wrote:
On Wed, Oct 04, 2023, Paul Durrant wrote:
From: Paul Durrant <pdurrant@xxxxxxxxxx>

Upstream Xen now ignores this flag [1], since the only guest kernel ever to
use it was buggy. By ignoring the flag the guest will always get a callback
if it sets a negative timeout which upstream Xen has determined not to
cause problems for any guest setting the flag.

[1] https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=19c6cbd909

Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
---
Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Cc: Sean Christopherson <seanjc@xxxxxxxxxx>
Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Cc: x86@xxxxxxxxxx

If you're going to manually Cc folks, put the Cc's in the changelog proper so that
there's a record of who was Cc'd on the patch.


FTR, the basic list was generated:

./scripts/get_maintainer.pl --no-rolestats 0001-KVM-xen-ignore-the-VCPU_SSHOTTMR_future-flag.patch | while read line; do echo Cc: $line; done

and then lightly hacked put x86 at the end and remove my own name... so not really manual.
Also not entirely sure why you'd want the Cc list making it into the actual commit.

Or even better, just use scripts/get_maintainers.pl and only manually Cc people
when necessary.

I guess this must be some other way of using get_maintainers.pl that you are expecting?