Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

[Michael Tretter]

On Wed, 27 Sep 2023 07:47:53 -0500, Adam Ford wrote:
> On Sun, Sep 3, 2023 at 8:05 PM Inki Dae <daeinki@xxxxxxxxx> wrote:
> >
> > 2023년 8월 29일 (화) 오전 7:38, Adam Ford <aford173@xxxxxxxxx>님이 작성:
> > >
> > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter
> > > <m.tretter@xxxxxxxxxxxxxx> wrote:
> > > >
> > > > From: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > > >
> > > > Since the MIPI configuration can be changed on demand it is very useful
> > > > to print more MIPI settings during the MIPI device attach step.
> > > >
> > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
> > >
> > > Reviewed-by: Adam Ford <aford173@xxxxxxxxx>  #imx8mm-beacon
> > > Tested-by: Adam Ford <aford173@xxxxxxxxx>  #imx8mm-beacon
> >
> > Reviewed-by: Inki Dae <inki.dae@xxxxxxxxxxx>
> > Acked-by: Inki Dae <inki.dae@xxxxxxxxxxx>
> 
> What needs to be done in order to get this accepted?  This series is a
> very nice improvement in i.MX8M Mini / Nano.

I think it is my turn to send a v2 that addresses the review comments. I'll
try to find time this week.

Michael

> 
> adam
> >
> > >
> > > > ---
> > > >  drivers/gpu/drm/bridge/samsung-dsim.c | 5 ++++-
> > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > index 73ec60757dbc..6778f1751faa 100644
> > > > --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > @@ -1711,7 +1711,10 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host,
> > > >                 return ret;
> > > >         }
> > > >
> > > > -       DRM_DEV_INFO(dev, "Attached %s device\n", device->name);
> > > > +       DRM_DEV_INFO(dev, "Attached %s device (lanes:%d bpp:%d mode-flags:0x%lx)\n",
> > > > +                    device->name, device->lanes,
> > > > +                    mipi_dsi_pixel_format_to_bpp(device->format),
> > > > +                    device->mode_flags);
> > > >
> > > >         drm_bridge_add(&dsi->bridge);
> > > >
> > > >
> > > > --
> > > > 2.39.2
> > > >
>