Re: [PATCH v2] wifi: wfx: fix case where rates are out of order

From: Kalle Valo
Date: Wed Oct 04 2023 - 09:22:19 EST


Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> writes:

>> > v2:
>> > - Fix malformed tags in commit body. (checkpatch still complains about
>> > missing Close tag, but the bug tracker is not public and I don't have
>> > the exact URL)
>>
>> Just out of curiosity why does the checkpatch complain about a missing
>> Close tag? I don't get it why there should be one.
>
> I am on top of v6.6-rc3. I get:
>
> $ ./scripts/checkpatch.pl -g HEAD^..HEAD
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #26:
> best ____________rate__________ ____statistics___ _____last____ ______sum-of________
>
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #57:
> Reported-by: Alexandr Suslenko <suslenko.o@ajax.systems>
> Co-developed-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> [...]

Ah, thanks. Now I understand. But that rule doesn't make any sense to
me, for example I get reports privately as well and add a Reported-by
without a Closes tag. So always feel free to ignore that checkpatch
warning.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches