Re: [PATCH 09/21] block: Add checks to merging of atomic writes

From: John Garry
Date: Wed Oct 04 2023 - 07:40:54 EST


On 02/10/2023 23:50, Nathan Chancellor wrote:
ld.lld: error: undefined symbol: __moddi3
>>> referenced by blk-merge.c
>>> block/blk-merge.o:(ll_back_merge_fn) in archive vmlinux.a
>>> referenced by blk-merge.c
>>> block/blk-merge.o:(ll_back_merge_fn) in archive vmlinux.a
>>> referenced by blk-merge.c
>>> block/blk-merge.o:(bio_attempt_front_merge) in archive vmlinux.a
>>> referenced 3 more times
This does not appear to be clang specific, I can reproduce it with GCC
12.3.0 and the same configuration target.

Yeah, I just need to stop using the modulo operator for 64b values, which I had already been advised to :|

Thanks,
John