Re: [PATCH V13 4/4] arm64: dts: ipq6018: add pwm node

From: Devi Priya
Date: Wed Oct 04 2023 - 05:46:08 EST




On 10/4/2023 3:13 PM, Krzysztof Kozlowski wrote:
On 04/10/2023 11:04, Devi Priya wrote:
Describe the PWM block on IPQ6018.

The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
&pwm as child of &tcsr.


...

v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)

arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index e59b9df96c7e..429ad7cb681c 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -390,8 +390,21 @@ tcsr_mutex: hwlock@1905000 {
};
tcsr: syscon@1937000 {
- compatible = "qcom,tcsr-ipq6018", "syscon";
+ compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
reg = <0x0 0x01937000 0x0 0x21000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x01937000 0x21000>;

Please put ranges just after reg.
Sure, okay

With that:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Thank you!

Regards,
Devi Priya

Best regards,
Krzysztof