Re: [PATCH net-next v4 00/18] net/smc: implement virtual ISM extension and loopback-ism

From: Wen Gu
Date: Wed Oct 04 2023 - 04:42:47 EST




On 2023/9/29 21:31, Alexandra Winter wrote:


On 28.09.23 19:29, Wen Gu wrote:


On 2023/9/28 16:56, Alexandra Winter wrote:


On 27.09.23 17:16, Alexandra Winter wrote:
Hello Wen Gu,

I applied and built your patches and noticed some things that you may want to consider in the next version:


FYI, patchwork basically complains about many the same issues:
https://patchwork.kernel.org/project/netdevbpf/list/?series=787037&state=*

In general you should run those check BEFORE you send the patches and not rely on patchwork.
Thank you Sandy. I seem to have not seen the specific content of these checks. May I ask how to
run those patchwork check locally? So that I can make sure everything is ok before send them.


Citing from Documentation/process/maintainer-netdev.rst :

"patchwork checks
~~~~~~~~~~~~~~~~

Checks in patchwork are mostly simple wrappers around existing kernel
scripts, the sources are available at:

https://github.com/kuba-moo/nipa/tree/master/tests

**Do not** post your patches just to run them through the checks.
You must ensure that your patches are ready by testing them locally
before posting to the mailing list. The patchwork build bot instance
gets overloaded very easily and netdev@vger really doesn't need more
traffic if we can help it."

HTH

Thank you! Sandy.