Re: [PATCH v10 16/16] drm/mediatek: aal: Compress of_device_id entries and add sentinel

From: CK Hu (胡俊光)
Date: Tue Oct 03 2023 - 23:57:18 EST


Hi, Angelo:

On Fri, 2023-08-04 at 09:28 +0200, AngeloGioacchino Del Regno wrote:
> Compress the entry for mediatek,mt8173-disp-aal, as it fits in one
> line, and fix the style; while at it, also add the usual sentinel
> comment to the last entry.
>
> This commit brings no functional changes.

Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>

>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_aal.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> b/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> index e6ab3eaa1126..70de5f3007e4 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> @@ -212,10 +212,9 @@ static const struct mtk_disp_aal_data
> mt8173_aal_driver_data = {
> };
>
> static const struct of_device_id mtk_disp_aal_driver_dt_match[] = {
> - { .compatible = "mediatek,mt8173-disp-aal",
> - .data = &mt8173_aal_driver_data},
> - { .compatible = "mediatek,mt8183-disp-aal"},
> - {},
> + { .compatible = "mediatek,mt8173-disp-aal", .data =
> &mt8173_aal_driver_data },
> + { .compatible = "mediatek,mt8183-disp-aal" },
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_disp_aal_driver_dt_match);
>