Re: [PATCH v2 1/4] ACPI: PCC: Add PCC shared memory region command and status bitfields

[Rafael J. Wysocki]

On Wed, Sep 27, 2023 at 6:32 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>
> Define the common macros to use when referring to various bitfields in
> the PCC generic communications channel command and status fields.
>
> Currently different drivers that need to use these bitfields have defined
> these locally. This common macro is intended to consolidate and replace
> those.
>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
>  include/acpi/pcc.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
> index 73e806fe7ce7..021891a7434f 100644
> --- a/include/acpi/pcc.h
> +++ b/include/acpi/pcc.h
> @@ -18,7 +18,20 @@ struct pcc_mbox_chan {
>         u16 min_turnaround_time;
>  };
>
> +/* Generic Communications Channel Shared Memory Region */
> +#define PCC_SIGNATURE                  0x50424300
> +/* Generic Communications Channel Command Field */
> +#define PCC_CMD_GENERATE_DB_INTR       BIT(15)
> +/* Generic Communications Channel Status Field */
> +#define PCC_STATUS_CMD_COMPLETE                BIT(0)
> +#define PCC_STATUS_SCI_DOORBELL                BIT(1)
> +#define PCC_STATUS_ERROR               BIT(2)
> +#define PCC_STATUS_PLATFORM_NOTIFY     BIT(3)
> +/* Initiator Responder Communications Channel Flags */
> +#define PCC_CMD_COMPLETION_NOTIFY      BIT(0)
> +
>  #define MAX_PCC_SUBSPACES      256
> +
>  #ifdef CONFIG_PCC
>  extern struct pcc_mbox_chan *
>  pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id);
>
> --

Do you want me to pick up this lot?