Re: [PATCH 2/3] Input: cap11xx - Convert to use maple tree register cache

From: Mark Brown
Date: Tue Oct 03 2023 - 08:16:37 EST


On Mon, Oct 02, 2023 at 11:16:51PM -0700, Dmitry Torokhov wrote:
> On Sun, Oct 01, 2023 at 01:43:39AM +0200, Mark Brown wrote:

> > - .cache_type = REGCACHE_RBTREE,
> > + .cache_type = REGCACHE_MAPLE,

> I do not think these driver care much about the cache type. Optimal one
> might even depend on the architecture. I wonder if we could have
> something like REGCACHE_DEFAULT to signal that whatever is the "best
> default" implementation it should be used?

I do sometimes wonder about that but there's also been enough issues
with the earlier stage of the transition and shaking out bugs in the
new code that it makes me a bit nervous about using one. It has also
been a useful exercise to go through and actually look at the users, but
that could be done any time.

Attachment: signature.asc
Description: PGP signature