Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding

From: Krzysztof Kozlowski
Date: Tue Oct 03 2023 - 05:23:07 EST


On 03/10/2023 00:32, Shawn Anastasio wrote:
> The SIE Cronos Platform Controller CPLD is a multi-purpose platform

What is SIE? Vendor prefix says sony.

What is Cronos?


> controller that provides both a watchdog timer and an LED controller. As
> both functions are provided by the same CPLD, a multi-function device is
> exposed as the parent of both functions.

A nit, subject: drop second/last, redundant "DT binding". The
"dt-bindings" prefix is already stating that these are bindings.

>
> Add a DT binding for this device.
>
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>

Except that this was clearly no tested...

> ---

...

> +properties:
> + compatible:
> + const: sie,cronos-cpld
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1

Why do you need it?

> +
> + '#size-cells':
> + const: 1

Also looks unneeded.

> +
> + leds:
> + type: object
> + description: Cronos Platform Status LEDs

Missing additionalProperties:false... but anyway this is just empty. No
resources? Drop the node.

> +
> + properties:
> + compatible:
> + const: sie,cronos-leds
> +
> + watchdog:
> + type: object
> + description: Cronos Platform Watchdog Timer
> +
> + properties:
> + compatible:
> + const: sie,cronos-watchdog

No resources? Drop the node.

Best regards,
Krzysztof