Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()

From: Andy Shevchenko
Date: Tue Oct 03 2023 - 04:55:06 EST

Next message: Köry Maincent: "[PATCH net 1/1] ethtool: Fix mod state of verbose no_mask bitset"
Previous message: Dan Carpenter: "drivers/block/drbd/drbd_worker.c:588 make_resync_request() warn: variable dereferenced before check 'peer_device' (see line 587)"
In reply to: Bartosz Golaszewski: "[PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()"
Next in thread: Andrew Jeffery: "Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Oct 03, 2023 at 09:39:26AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
> numberspace, not the controller-relative offset, which needs to be added
> to the chip base.

Right, because it has no clue what chip this offset is related to.
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko

Next message: Köry Maincent: "[PATCH net 1/1] ethtool: Fix mod state of verbose no_mask bitset"
Previous message: Dan Carpenter: "drivers/block/drbd/drbd_worker.c:588 make_resync_request() warn: variable dereferenced before check 'peer_device' (see line 587)"
In reply to: Bartosz Golaszewski: "[PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()"
Next in thread: Andrew Jeffery: "Re: [PATCH] gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]