[tip: locking/core] locking/debug: Fix debugfs API return value checks to use IS_ERR()

From: tip-bot2 for Atul Kumar Pant
Date: Tue Oct 03 2023 - 04:31:42 EST


The following commit has been merged into the locking/core branch of tip:

Commit-ID: 8788c6c2feb3600ba1a2f84ac5d258af4a284cea
Gitweb: https://git.kernel.org/tip/8788c6c2feb3600ba1a2f84ac5d258af4a284cea
Author: Atul Kumar Pant <atulpant.linux@xxxxxxxxx>
AuthorDate: Mon, 07 Aug 2023 17:48:34 +05:30
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Tue, 03 Oct 2023 10:11:25 +02:00

locking/debug: Fix debugfs API return value checks to use IS_ERR()

Update the checking of return values from debugfs_create_file()
and debugfs_create_dir() to use IS_ERR().

Signed-off-by: Atul Kumar Pant <atulpant.linux@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Acked-by: Waiman Long <longman@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230807121834.7438-1-atulpant.linux@xxxxxxxxx
---
kernel/locking/lock_events.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/locking/lock_events.c b/kernel/locking/lock_events.c
index fa2c2f9..e68d820 100644
--- a/kernel/locking/lock_events.c
+++ b/kernel/locking/lock_events.c
@@ -146,7 +146,7 @@ static int __init init_lockevent_counts(void)
struct dentry *d_counts = debugfs_create_dir(LOCK_EVENTS_DIR, NULL);
int i;

- if (!d_counts)
+ if (IS_ERR(d_counts))
goto out;

/*
@@ -159,14 +159,14 @@ static int __init init_lockevent_counts(void)
for (i = 0; i < lockevent_num; i++) {
if (skip_lockevent(lockevent_names[i]))
continue;
- if (!debugfs_create_file(lockevent_names[i], 0400, d_counts,
- (void *)(long)i, &fops_lockevent))
+ if (IS_ERR(debugfs_create_file(lockevent_names[i], 0400, d_counts,
+ (void *)(long)i, &fops_lockevent)))
goto fail_undo;
}

- if (!debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
+ if (IS_ERR(debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
d_counts, (void *)(long)LOCKEVENT_reset_cnts,
- &fops_lockevent))
+ &fops_lockevent)))
goto fail_undo;

return 0;