Re: [PATCH v4 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

From: Andy Shevchenko
Date: Mon Oct 02 2023 - 15:46:16 EST


On Mon, Oct 2, 2023 at 10:41 PM Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.

...

> + pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL);
> + if (IS_ERR(pltfm_host->clk)) {
> + ret = PTR_ERR(pltfm_host->clk);
> + goto err_sdhci;
> + }

...

> +err_sdhci_clk:
> + clk_disable_unprepare(pltfm_host->clk);

Now this is leftover that leads to unbalanced reference counting.

--
With Best Regards,
Andy Shevchenko