RE: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device' error

From: Biju Das
Date: Mon Oct 02 2023 - 05:57:17 EST


> Subject: Re: [PATCH] iio: magnetometer: ak8975: Fix 'Unexpected device'
> error
>
> On Mon, Oct 02, 2023 at 09:38:17AM +0000, Biju Das wrote:
> > > On Mon, Oct 02, 2023 at 10:27:45AM +0100, Jonathan Cameron wrote:
> > > > On Sun, 1 Oct 2023 18:09:56 +0200
> > > > André Apitzsch <git@xxxxxxxxxxx> wrote:
> > >
> > > > > Fixes: 4f9ea93afde1 ("iio: magnetometer: ak8975: Convert
> > > > > enum->pointer for data in the match tables")
> > >
> > > ^^^ (1)
>
> ...
>
> > > > So we need the spacer until someone converts this driver to use
> > > > pointers instead for both of and ACPI tables.
> > >
> > > Isn't it done by (1) which is in your tree?
> >
> > How (1) can trigger 'Unexpected device' error??
> > It returns match_data, and match_data has correct device type.
>
> How? The enum starts from 0 with a AKXXXX and ak_def_array starts from 0
> indexing, it's classical off-by-one, you got the driver data for a wrong
> chip.

Got it. I was about to reply. It just needs mapping as Andre did here.

Cheers,
Biju