Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep

From: Alice Ryhl
Date: Mon Oct 02 2023 - 03:52:14 EST


On Thu, Sep 28, 2023 at 10:14 PM Matthew Maurer <mmaurer@xxxxxxxxxx> wrote:
>
> While GNU grep supports '\|' when in basic regular expression mode, not
> all grep implementations do (notably toybox grep, used to build the
> Android kernel, does not). Switching to grep -Ev enables extended
> regular expresions which includes support for the '|' operator.
>
> Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>

LGTM. I tested this in my Android build.

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Tested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>