Re: [PATCH] selftests:proc add missing field KSM in smaps_rollup[] array

From: Andrew Morton
Date: Sun Oct 01 2023 - 15:52:56 EST


On Sat, 30 Sep 2023 17:55:23 +0530 Swarup Laxman Kotiaklapudi <swarupkotikalapudi@xxxxxxxxx> wrote:

> Missing field KSM is added in g_smaps_rollup[] array as it
> fixes assert in function test_proc_pid_smaps_rollup()
>
> Without this patchset test fails for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ...
> selftests: proc: proc-empty-vm
> proc-empty-vm: proc-empty-vm.c:299: test_proc_pid_smaps_rollup:
> Assertion `rv == sizeof(g_smaps_rollup) - 1' failed.
> /usr/bin/timeout: the monitored command dumped core
> Aborted
> not ok 5 selftests: proc: proc-empty-vm # exit=134
> ...
>
> With this patchset test passes for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ....
> timeout set to 45
> selftests: proc: proc-empty-vm
> ok 5 selftests: proc: proc-empty-vm
> ....
>

Thanks. We fixed this in

commit 9d1be94df5acd486b157e85ffa53d344e5b17e22
Author: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Date: Thu Sep 7 14:10:12 2023 +0300

selftests/proc: fixup proc-empty-vm test after KSM changes