Re: [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors

[Duje Mihanović]

On 10/1/2023 4:32 PM, Andy Shevchenko wrote:
> > +       pxa_ohci->usb_host = gpiod_get_optional(&pdev->dev, "usb-host", GPIOD_OUT_LOW);
> > +       if (IS_ERR(pxa_ohci->usb_host))
> > +               dev_warn(&pdev->dev, "failed to get USB host GPIO with %pe\n",
> > +                               pxa_ohci->usb_host);
>
> Since you are using _optional() API, you need to bail out on the error
> case and replace dev_warn() by dev_err(). I guess I already commented
> on this. What is the rationale to not follow my comment?

I must have missed it, sorry about that. I'll be sure to do so in v5.

Regards,
Duje