Re: [PATCH v6 06/14] can: m_can: Add rx coalescing ethtool support

From: Simon Horman
Date: Sun Oct 01 2023 - 08:24:02 EST


On Fri, Sep 29, 2023 at 04:12:56PM +0200, Markus Schneider-Pargmann wrote:
> Add the possibility to set coalescing parameters with ethtool.
>
> rx-frames-irq and rx-usecs-irq can only be set and unset together as the
> implemented mechanism would not work otherwise. rx-frames-irq can't be
> greater than the RX FIFO size.
>
> Also all values can only be changed if the chip is not active.
>
> Polling is excluded from irq coalescing support.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>