Re: [PATCH][next] ALSA: 6fire: Fix undefined behavior bug in struct midi_runtime

[Gustavo A. R. Silva]

On 9/29/23 19:27, Kees Cook wrote:
> On Fri, Sep 29, 2023 at 06:06:32PM +0200, Gustavo A. R. Silva wrote:
> > `struct urb` is a flexible structure, which means that it contains a
> > flexible-array member at the bottom. This could potentially lead to an
> > overwrite of the objects following `out_urb` in `struct midi_runtime`,
> > among them a function pointer.
> >
> > Fix this by placing the declaration of object `out_urb` at the end of
> > `struct midi_runtime`.
> >
> > Fixes: c6d43ba816d1 ("ALSA: usb/6fire - Driver for TerraTec DMX 6Fire USB")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Another good find. :)

There are more coming. :)

> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks!
--
Gustavo