Re: [PATCH 3/5] power: supply: rt5033_charger: fix missing unlock

[Sebastian Reichel]

Hi,

On Thu, Sep 28, 2023 at 09:46:33PM +0200, Jakob Hauser wrote:
> On 28.09.23 07:23, Marion & Christophe JAILLET wrote:
> > Ok, but why not already in patch #1?
> 
> Thanks for your hints about the missing "unlock"s. And sorry for causing you
> extra work by having the fix in a separate patch.
> 
> The patch you refer to ("power: supply: rt5033_charger: Add cable detection
> and USB OTG supply") has its own history. It was already applied once,
> showed up in linux-next, caused some issues, was therefore removed again. In
> the meantime, some fixes were provided by different contributors.

Since the commit has been dropped, please merge the fixes into the
patch. E.g. patch #1 does not make any sense on its own.

> This series actually tries to apply that patch again, accompanied by two
> fixes – and two additional clean-up patches. I added the fixes patches
> as-is, also to credit the contributors.

You can use Co-developed-by tag for that.

> Possibly the cover sheet of the series was a bit too thin about that
> history.
> 
> Kind regards,
> Jakob

Patches 4-5 look fine to me, but do not apply without 1-3. For 1-3 I
did not check them in detail. Please merge them first, since it's
quite hard to read in the current state.

Thanks,

-- Sebastian

Attachment: signature.asc
Description: PGP signature