Re: [PATCH 1/2] dt-bindings: usb: Add T-HEAD TH1520 USB controller

From: Krzysztof Kozlowski
Date: Sat Sep 30 2023 - 11:52:35 EST


On 28/09/2023 07:21, Krzysztof Kozlowski wrote:
> Drop stray blank line
>
>> + usb {
>> + compatible = "thead,th1520-usb";
>
> Use 4 spaces for example indentation.
>
>> + reg = <0xec03f000 0x1000>;
>> + clocks = <&clk 1>,
>> + <&clk 2>,
>> + <&clk 3>,
>> + <&clk 4>;
>> + clock-names = "ref", "bus_early", "phy", "suspend";
>> + ranges;
>
> Are you sure you do not have W=1 warnings in DTS?

Ah, as we can see from bot's report, you have warnings. Please test your
DTS with dtbs_check W=1 and fix all (*ALL*) warnings.

This looks like missing proper addresses in the ranges.

Best regards,
Krzysztof