Re: [PATCH v3 1/8] selftests: Add printf attribute to ksefltest prints

From: Reinette Chatre
Date: Fri Sep 29 2023 - 18:31:46 EST


Hi Maciej,

In subject: ksefltest -> kselftest

On 9/22/2023 2:06 AM, Maciej Wieczor-Retman wrote:
> Kselftest header defines multiple variadic functions that use printf
> along with other logic.
>
> There is no format checking for the variadic functions that use
> printing inside kselftest.h. Because of this the compiler won't
> be able to catch instances of mismatched printf formats and debugging
> tests might be more difficult.
>
> Add the common __printf attribute macro to kselftest.h.
>
> Add __printf attribute to every function using formatted printing with
> variadic arguments.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx>

With typo fixed:
Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette