Re: [PATCH 2/3] platform/x86: ISST: Allow level 0 to be not present

[Ilpo Järvinen]

On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:

> It is possible that SST level 0 or base level is not present in some
> configurations. So don't set level 0 mask in level_en_mask by default.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> index 48465636aadb..e6d84ce0e7a5 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> @@ -372,9 +372,6 @@ static int sst_main(struct auxiliary_device *auxdev, struct tpmi_per_power_domai
>  	/* Read PP header */
>  	*((u64 *)&pd_info->pp_header) = readq(pd_info->sst_base + pd_info->sst_header.pp_offset);
>  
> -	/* Force level_en_mask level 0 */
> -	pd_info->pp_header.level_en_mask |= 0x01;
> -
>  	mask = 0x01;
>  	levels = 0;
>  	for (i = 0; i < 8; ++i) {
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


-- 
 i.