Re: [PATCH V12 3/3] arm64: dts: ipq6018: add pwm node

[Devi Priya]

On 9/25/2023 12:29 PM, Devi Priya wrote:
> Describe the PWM block on IPQ6018.
>
> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
> &pwm as child of &tcsr.
>
> Add also ipq6018 specific compatible string.
>
> Co-developed-by: Baruch Siach <baruch.siach@xxxxxxxxx>
> Signed-off-by: Baruch Siach <baruch.siach@xxxxxxxxx>
> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> ---
> v12:
>
>    No change
>
> v11:
>
>    No change
>
> v10:
>
>    No change
>
> v9:
>
>    Add 'ranges' property (Rob)
>
> v8:
>
>    Add size cell to 'reg' (Rob)
>
> v7:
>
>    Use 'reg' instead of 'offset' (Rob)
>
>    Add qcom,tcsr-ipq6018 (Rob)
>
>    Drop clock-names (Bjorn)
>
> v6:
>
>    Make the PWM node child of TCSR (Rob Herring)
>
>    Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
>
> v5: Use qcom,pwm-regs for TCSR phandle instead of direct regs
>
> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>
>   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 47b8b1d6730a..cadd2c583526 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -398,8 +398,21 @@ tcsr_mutex: hwlock@1905000 {
>   		};
>   
>   		tcsr: syscon@1937000 {
> -			compatible = "qcom,tcsr-ipq6018", "syscon";
> +			compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>   			reg = <0x0 0x01937000 0x0 0x21000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0x0 0x01937000 0x21000>;
> +
Hi Krzysztof,
Referring to 
https://lore.kernel.org/all/20220909091056.128949-1-krzysztof.kozlowski@xxxxxxxxxx/, 
it seems that the TCSR block should
not have any child nodes. Could you pls provide your suggestions on pwm
being added as the child node?

Thanks,
Devi Priya
> +			 pwm: pwm@a010 {
> +				compatible = "qcom,ipq6018-pwm";
> +				reg = <0xa010 0x20>;
> +				clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +				assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +				assigned-clock-rates = <100000000>;
> +				#pwm-cells = <2>;
> +				status = "disabled";
> +			};
>   		};
>   
>   		usb2: usb@70f8800 {