Re: [RESEND PATCH 2/2] locking/x86: Wire up sync_try_cmpxchg

[Ingo Molnar]

* Uros Bizjak <ubizjak@xxxxxxxxx> wrote:

> On Thu, Sep 28, 2023 at 10:53 PM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> >
> > * Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
> >
> > > Implement target specific support for sync_try_cmpxchg.
> >
> > Could you please provide a before/after description of how
> > this improves things exactly?
> 
> The improvement [1] was demonstrated in the original patch submission.

What I'm saying: please integrate the required context & arguments into the 
changelogs of the patches you submit.

Patches that change code generation should demonstrate what they achieve.

 - If existing code changes, then describe/demonstrate it with disassembly.

 - If existing code generation is unchanged, then *declare that property in 
   the changelog*, and mention that a future patch relies those changes.

You can either include that future patch in this series, or you can 
describe/demonstrate the benefits in the changelog while noting that those 
changes will come in future patches.

Your submission, as-is, provided no context whatsoever, it described only 
the 'how', not the 'why'.

Thanks,

	Ingo