Re: [PATCH 6/7] riscv: report misaligned accesses emulation to hwprobe

From: kernel test robot
Date: Thu Sep 28 2023 - 21:03:32 EST


Hi Clément,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6-rc3 next-20230928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Cl-ment-L-ger/riscv-remove-unused-functions-in-traps_misaligned-c/20230926-230654
base: linus/master
patch link: https://lore.kernel.org/r/20230926150316.1129648-7-cleger%40rivosinc.com
patch subject: [PATCH 6/7] riscv: report misaligned accesses emulation to hwprobe
config: riscv-randconfig-002-20230929 (https://download.01.org/0day-ci/archive/20230929/202309290842.Dk0K2nsp-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309290842.Dk0K2nsp-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309290842.Dk0K2nsp-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

arch/riscv/kernel/traps_misaligned.c: In function 'handle_misaligned_load':
arch/riscv/kernel/traps_misaligned.c:420:48: error: 'struct thread_struct' has no member named 'align_ctl'
420 | if (user_mode(regs) && (current->thread.align_ctl & PR_UNALIGN_SIGBUS))
| ^
arch/riscv/kernel/traps_misaligned.c: In function 'handle_misaligned_store':
arch/riscv/kernel/traps_misaligned.c:522:48: error: 'struct thread_struct' has no member named 'align_ctl'
522 | if (user_mode(regs) && (current->thread.align_ctl & PR_UNALIGN_SIGBUS))
| ^
arch/riscv/kernel/traps_misaligned.c: In function 'check_unaligned_access_emulated':
>> arch/riscv/kernel/traps_misaligned.c:610:17: error: expected ':' or ')' before '_ASM_EXTABLE'
610 | _ASM_EXTABLE(1b, 2b)
| ^~~~~~~~~~~~
>> arch/riscv/kernel/traps_misaligned.c:610:30: error: invalid suffix "b" on integer constant
610 | _ASM_EXTABLE(1b, 2b)
| ^~
arch/riscv/kernel/traps_misaligned.c:610:34: error: invalid suffix "b" on integer constant
610 | _ASM_EXTABLE(1b, 2b)
| ^~
>> arch/riscv/kernel/traps_misaligned.c:602:37: warning: unused variable 'tmp_var' [-Wunused-variable]
602 | unsigned long emulated = 1, tmp_var;
| ^~~~~~~


vim +610 arch/riscv/kernel/traps_misaligned.c

599
600 bool check_unaligned_access_emulated(int cpu)
601 {
> 602 unsigned long emulated = 1, tmp_var;
603
604 /* Use a fixup to detect if misaligned access triggered an exception */
605 __asm__ __volatile__ (
606 "1:\n"
607 " "REG_L" %[tmp], 1(%[ptr])\n"
608 " li %[emulated], 0\n"
609 "2:\n"
> 610 _ASM_EXTABLE(1b, 2b)
611 : [emulated] "+r" (emulated), [tmp] "=r" (tmp_var)
612 : [ptr] "r" (&tmp_var)
613 : "memory");
614
615 if (!emulated)
616 return false;
617
618 per_cpu(misaligned_access_speed, cpu) =
619 RISCV_HWPROBE_MISALIGNED_EMULATED;
620
621 return true;
622 }
623

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki