Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions

[Jeff Johnson]

On 9/28/2023 8:31 AM, Kalle Valo wrote:
> Christian Lamparter <chunkeey@xxxxxxxxx> writes:
>
> > On 9/19/23 06:49, Wu Yunchuan wrote:
> > > No need cast (void *) to (struct ar9170 *), (u8 *) or (void*).
> >
> > hmm, your mail went into the spam folder. Good thing I checked.
> >
> >  From what I remember: The reason why these casts were added in
> > carl9170 was because of compiler warnings/complaints.
> > Current gcc compilers should be OK (given that the kernel-bot
> > didn't react, or went your Mail to their spam-folder as well?)
> > but have you checked these older versions?
>
> Do you remember anything more about these warnings? I tried to check the
> git history and at least quickly couldn't find anything related to this.
>
> The changes look very safe to me, struct urb::context field and the out
> variable are both of type 'void *' so removing the explicit casts should
> change anything. I cannot really come up a reason why would this patch
> cause new warnings so I am inclined towards taking this patch. What do
> you think?

Anything that would have had issue would have predated C99.
This change is safe.