Re: [PATCH v2 1/2] spi: renesas,rzv2m-csi: Add CSI (SPI) target related property

From: Rob Herring
Date: Thu Sep 28 2023 - 14:32:19 EST



On Wed, 27 Sep 2023 17:25:07 +0100, Fabrizio Castro wrote:
> The CSI IP found inside the Renesas RZ/V2M SoC can also work
> in SPI target mode.
> When working in target mode, the IP will make use of the SS
> (Slave Selection) pin, with "low" as default active level.
> The active level of SS can be changed to "high" upon setting
> property "spi-cs-high" to true.
> By default, the SS will be used in target mode, unless property
> "renesas,csi-no-ss" is set to true, in which case data will be
> shifted in and out purely based on clock activity, and the
> logic level of the SS pin will be completely ignored.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> ---
> v1->v2: I have dropped properties renesas,csi-ss and
> renesas,csi-ss-high. I have added property
> renesas,csi-no-ss, and to configure SS as active
> high one now needs to use property spi-cs-high.
> I have also reworded the changelog to use a more
> modern terminology (host and target as opposed to
> master and slave).
>
> .../devicetree/bindings/spi/renesas,rzv2m-csi.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>