Re: (subset) [PATCH] leds: lp3952: replace deprecated strncpy with strscpy

From: Lee Jones
Date: Thu Sep 28 2023 - 09:41:36 EST


On Fri, 22 Sep 2023 15:27:17 +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect `dest` to be NUL-terminated due to its use with dev_err.
>
> lp3952_get_label()'s dest argument is priv->leds[i].name:
> | acpi_ret = lp3952_get_label(&priv->client->dev, led_name_hdl[i],
> | priv->leds[i].name);
> ... which is then assigned to:
> | priv->leds[i].cdev.name = priv->leds[i].name;
> ... which is used with a format string
> | dev_err(&priv->client->dev,
> | "couldn't register LED %s\n",
> | priv->leds[i].cdev.name);
>
> [...]

Applied, thanks!

[1/1] leds: lp3952: replace deprecated strncpy with strscpy
commit: 821d3ff4b4e2c689576a623348555114e3f2f1c2

--
Lee Jones [李琼斯]