Re: [PATCH 00/27] platform: Convert to platform remove callback returning void

From: Ilpo Järvinen
Date: Thu Sep 28 2023 - 07:03:28 EST


On Wed, 27 Sep 2023, Uwe Kleine-König wrote:

> Hello,
>
> this series converts all platform drivers below drivers/platform to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> As there is no single maintainer team for drivers/platform, I suggest
> the individual maintainers to pick up "their" patches. The only
> inter-dependency in this series is that the patches #24 - #27 depend on
> #23. Otherwise there are no inter-dependencies, so that should work
> fine. As there are still quite a few drivers to convert in other areas
> than drivers/platform, I'm happy about every patch that makes it in and
> there is no need for further coordination. So even if there is a merge
> conflict with one patch until you apply or a subject prefix is
> suboptimal, please don't let you stop by negative feedback for other
> patches (unless it applies to "your" patches, too, of course).
>
> Best regards and thanks for considering,
> Uwe
>
> Uwe Kleine-König (27):
> platform/chrome: cros_ec_chardev: Convert to platform remove callback
> returning void
> platform/chrome: cros_ec_debugfs: Convert to platform remove callback
> returning void
> platform/chrome: cros_ec_lightbar: Convert to platform remove callback
> returning void
> platform/chrome: cros_ec_lpc: Convert to platform remove callback
> returning void
> platform/chrome: cros_ec_sysfs: Convert to platform remove callback
> returning void
> platform/chrome: cros_ec_vbc: Convert to platform remove callback
> returning void
> platform/chrome: cros_typec_switch: Convert to platform remove
> callback returning void
> platform/chrome: cros_usbpd_logger: Convert to platform remove
> callback returning void
> platform/chrome: cros_usbpd_notify: Convert to platform remove
> callback returning void
> platform/chrome/wilco_ec: core: Convert to platform remove callback
> returning void
> platform/chrome/wilco_ec: debugfs: Convert to platform remove callback
> returning void
> platform/chrome/wilco_ec: telemetry: Convert to platform remove
> callback returning void
> platform/goldfish: goldfish_pipe: Convert to platform remove callback
> returning void
> platform/mellanox: mlxbf-bootctl: Convert to platform remove callback
> returning void
> platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback
> returning void
> platform/mellanox: mlxreg-hotplug: Convert to platform remove callback
> returning void
> platform/mellanox: mlxreg-io: Convert to platform remove callback
> returning void
> platform/mellanox: mlxreg-lc: Convert to platform remove callback
> returning void
> platform/mellanox: nvsw-sn2201: Convert to platform remove callback
> returning void
> platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback
> returning void
> platform/x86: mlx-platform: Convert to platform remove callback
> returning void
> platform/x86: sel3350-platform: Convert to platform remove callback
> returning void
> platform/x86/siemens: simatic-ipc-batt: Simplify
> simatic_ipc_batt_remove()
> platform/x86/siemens: simatic-ipc-batt: Convert to platform remove
> callback returning void
> platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform
> remove callback returning void
> platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to
> platform remove callback returning void
> platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform
> remove callback returning void

Thanks for the patches.

I don't know if you got the auto generated thank you email as it seemed to
hit a character encoding problem while sending the email out.

But in any case, I've applied patches 14-27 to my local review-ilpo branch
(they will eventually appear on the public repo too and propagate to
for-next).


--
i.