Re: [PATCH v3] pinctrl: tegra: Add support to display pin function

From: Luca Ceresoli
Date: Thu Sep 28 2023 - 02:53:29 EST


Hello Linus, Prathamesh,

On Wed, 27 Sep 2023 10:54:15 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Mon, Sep 25, 2023 at 6:30 PM Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> wrote:
>
> > The symptom is that i2c3 is not working anymore, the I2C lines being
> > always high. No other known issues at the moment.
>
> Hm....
>
> >> + {"nvidia,function", TEGRA_PINCONF_PARAM_FUNCTION},
> >
> > FYI, I reduced your patch to only this line plus the one in the
> > pinctrl-tegra.h and the problem appears as well.
>
> I think there is a conflict now, that the pinconf is "stealing" the function
> assignment from the pinmux call.
>
> It's just a debugprint, I will revert the patch, Luca can investigate and you

Thanks for the quick revert Linus.

> can test a new patch then we will merge that.

Prathamesh, if you send a new patch it would be great if you can Cc: me so I
can test it.

Best regards,
Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com