Re: [PATCH v2] staging: rtl8192u: ieee80211: renamed duplicate variable

From: Dan Carpenter
Date: Thu Sep 28 2023 - 00:58:36 EST


On Wed, Sep 27, 2023 at 11:32:20PM -0400, Gary Rookard wrote:
> This patch renames a duplicate variable found in both rtl8192e and
> rtl8192u causing the preprocesser/compiler to compile without error
> when in fact it should throw an error/break the build.
>
> Prototype in files:
> rtl8192e/rtllib.h remaining as ht_update_default_setting
> rtl8192u/ieee80211/ieee80211.h changed to __ht_update_default_setting
>
> Function in files:
> rtl8192e/rtl819x_HTProc.c remaining as ht_update_default_setting
> rtl8192u/ieee80211/rtl819x_HTProc.c changed to __ht_update_default_setting
>
> Referenced in files:
> staging/rtl8192e/rtllib_module.c remaining as ht_update_default_setting
> staging/rtl8192u/ieee80211_module.c changed to __ht_update_default_setting
>
> Linux Kernel Coding Style "cleanup", no change in runtime,
> staging/rtl8192e and rtl8192u compile/build before and after.
>
> Signed-off-by: Gary Rookard <garyrookard@xxxxxxxxxxxx>
> ---

This doesn't apply, and there is no Fixes tag to suggest when these bugs
were introduced.

regards,
dan carpenter