On Wed, Sep 27, 2023 at 10:07:15AM +0800, lihuisong (C) wrote:Thanks
Hi Sudeep,Sure I will take a look and include it in v2 if applicable.
在 2023/9/26 20:28, Sudeep Holla 写道:
Define the common macros to use when referring to various bitfields inCan you define the bit0 macros in the "flags" for Extended PCC Subspace
the PCC generic communications channel command and status fields.
Shared Memory Region?
Sorry for my mistake. I know this.
It is as per the specification.Currently different drivers that need to use these bitfields have definedWhy is this signature 0x50424300?
these locally. This common macro is intended to consolidate and replace
those.
Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
---
include/acpi/pcc.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
index 73e806fe7ce7..66d9934c2ee4 100644
--- a/include/acpi/pcc.h
+++ b/include/acpi/pcc.h
@@ -18,7 +18,18 @@ struct pcc_mbox_chan {
u16 min_turnaround_time;
};
+/* Generic Communications Channel Shared Memory Region */
+#define PCC_SIGNATURE 0x50424300
In ACPI spec, this signature is all 0x50434303.No, not exactly. It is just an example.
The PCC signature - The signature of a subspace is computed by a bitwise-or
of the value 0x50434300 with the subspace ID. For example, subspace 3 has
signature 0x50434303
I used 0x50424300 instead of 0x50424300 according to the spec.
And I see the driver you mentioned(drivers/soc/hisilicon/kunpeng_hccs.c)
is doing the right thing. I am bit confused as why you being the author
of the driver are now confused.