Re: [RESEND PATCH v6 17/20] drm/mediatek: Support MT8188 Padding in display driver

[Shawn Sung (宋孝謙)]

Hi CK,

On Thu, 2023-09-28 at 03:05 +0000, CK Hu (胡俊光) wrote:
> Hi, Hsiao-chien:
> 
> On Mon, 2023-09-11 at 15:42 +0800, Hsiao Chien Sung wrote:
> > Padding is a new display module on MT8188, it provides ability
> > to add pixels to width and height of a layer with specified colors.
> > 
> > Due to hardware design, Mixer in VDOSYS1 requires width of a layer
> > to be 2-pixel-align, or 4-pixel-align when ETHDR is enabled,
> > we need Padding to deal with odd width.
> > 
> > Please notice that even if the Padding is in bypass mode,
> > settings in register must be cleared to 0,
> > or undefined behaviors could happen.
> 
> You just set padding to bypass mode and not clear settings to 0. Any
> thing wrong?
> 

Since the deafult value of all the registers in Padding is zero, and
we are not using Padding currently, it's fine if we just set padding to
bypass mode witout clearing other registers.

The comment is just a reminder in case we forget it in the future.

Regards,
Hsiao Chien Sung