Re: [PATCH 1/3] mmap: Fix vma_iterator in error path of vma_merge()

From: Liam R. Howlett
Date: Wed Sep 27 2023 - 18:42:47 EST


* Matthew Wilcox <willy@xxxxxxxxxxxxx> [230927 16:06]:
> On Wed, Sep 27, 2023 at 12:07:44PM -0400, Liam R. Howlett wrote:
> > +++ b/mm/mmap.c
> > @@ -968,14 +968,14 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
> > vma_pgoff = curr->vm_pgoff;
> > vma_start_write(curr);
> > remove = curr;
> > - err = dup_anon_vma(next, curr);
> > + err = dup_anon_vma(next, curr, &anon_dup);
>
> This isn't bisectable. dup_anon_vma() doesn't gain a third argument
> until patch 2.

Ah, I'll respin and retest.

Sorry about that,
Liam