Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi()

[H. Peter Anvin]

On September 27, 2023 1:06:23 AM PDT, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>* xin@xxxxxxxxx <xin@xxxxxxxxx> wrote:
>
>> From: "Xin Li (Intel)" <xin@xxxxxxxxx>
>> 
>> exc_nmi() only takes one argument of type struct pt_regs *, but
>> asm_exc_nmi() calls it with 2 arguments. The second one passed
>> in %rsi seems a leftover, so simply remove it.
>> 
>> BTW, fix 2 slips in the comments.
>> 
>> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
>> Acked-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>
>> ---
>>  arch/x86/entry/entry_64.S | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
>
>I've split this into two patches, because the comment fixes
>are entirely unrelated to this patch.
>
>[ I've propagated the SOBs and Acked-by's to the two patches,
>  as I presume is fine by everyone involved? ]
>
>Thanks,
>
>	Ingo

Perfect, thanks!