Re: [PATCH 1/3] mmap: Fix vma_iterator in error path of vma_merge()

From: Andrew Morton
Date: Wed Sep 27 2023 - 13:14:15 EST


On Wed, 27 Sep 2023 12:07:44 -0400 "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx> wrote:

> When merging of the previous VMA fails after the vma iterator has been
> moved to the previous entry, the vma iterator must be advanced to ensure
> the caller takes the correct action on the next vma iterator event. Fix
> this by adding a vma_next() call to the error path.
>
> Users may experience higher CPU usage, most likely in very low memory
> situations.

Looking through this thread:

> Closes: https://lore.kernel.org/linux-mm/CAG48ez12VN1JAOtTNMY+Y2YnsU45yL5giS-Qn=ejtiHpgJAbdQ@xxxxxxxxxxxxxx/

I'm seeing no indication that the effect is CPU consumption? Jann is
excpecting bogus oom-killing?