Re: [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas

From: Conor Dooley
Date: Wed Sep 27 2023 - 11:13:38 EST


On Tue, Sep 26, 2023 at 11:44:42AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties as needed, and then add any missing properties
> flagged by the addition.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> ---
> .../devicetree/bindings/power/supply/sbs,sbs-manager.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> index f255f3858d08..2e21846463ba 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> @@ -47,6 +47,12 @@ patternProperties:
> "^i2c@[1-4]$":
> type: object
> $ref: /schemas/i2c/i2c-controller.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 1
> + maximum: 4
>
> examples:
> - |
> --
> 2.40.1
>

Attachment: signature.asc
Description: PGP signature