RE: [PATCH v5 06/11] iommu/vt-d: Set the nested domain to a device

From: Tian, Kevin
Date: Wed Sep 27 2023 - 02:40:54 EST


> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Thursday, September 21, 2023 3:54 PM
>
> +
> + /* Is s2_domain compatible with this IOMMU? */

Add more words on why prepare_attach uses s2_domain when the actual
attach is for s1

> + ret = prepare_domain_attach_device(&dmar_domain->s2_domain-
> >domain, dev);
> + if (ret) {
> + dev_err_ratelimited(dev, "s2 domain is not compatible\n");
> + return ret;
> + }
> +
> + ret = domain_attach_iommu(dmar_domain, iommu);
> + if (ret) {
> + dev_err_ratelimited(dev, "Failed to attach domain to
> iommu\n");
> + return ret;
> + }
> +