Re: [PATCH v2 3/6] selftests/resctrl: Move _GNU_SOURCE define into Makefile
From: Reinette Chatre
Date: Wed Sep 27 2023 - 01:32:41 EST
Hi Ilpo,
On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> Currently, _GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE
nitpick: If you do submit a new version, could you please drop the
"Currently".
> has a large impact on what gets defined when including headers either
> before or after it. This can result in compile failures if .c file
> decides to include a standard header file before resctrl.h.
>
> It is safer to define _GNU_SOURCE in Makefile so it is always defined
> regardless of in which order includes are done.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
Reinette