Re: [PATCH] zswap: change zswap's default allocator to zsmalloc

From: Nhat Pham
Date: Tue Sep 26 2023 - 16:06:39 EST


On Tue, Sep 26, 2023 at 12:29 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Fri, Sep 08, 2023 at 04:51:15PM -0700, Nhat Pham wrote:
> > Out of zswap's 3 allocators, zsmalloc is the clear superior in terms of
> > memory utilization, both in theory and as observed in practice, with its
> > high storage density and low internal fragmentation. zsmalloc is also
> > more actively developed and maintained, since it is the allocator of
> > choice for zswap for many users, as well as the only allocator for zram.
>
> Dumb question from an outside, why do we then even keep the other
> two allocators around?
>

Maybe legacy users who explicitly configure zbud/z3fold?
We have a couple internally, and have to manually undo
those configuration after we stop compiling these 2
allocators.

But yeah, I don't see why we should keep these 2 allocators
around. Time to deprecate them? :)