Re: [PATCH v4] regulator (max5970): Add hwmon support

[Guenter Roeck]

On Tue, Sep 26, 2023 at 05:28:15PM +0200, Mark Brown wrote:
> On Tue, Sep 19, 2023 at 07:48:23AM +0200, Naresh Solanki wrote:
> > Utilize the integrated 10-bit ADC in Max5970/Max5978 to enable voltage
> > and current monitoring. This feature is seamlessly integrated through
> > the hwmon subsystem.
> 
> Guenter, are you OK with the hwmon side of this?

Sorry, I lost track. Not really; see my response to the patch.

I think the memory allocation in that driver is a bit too complicated.
It trades simplicity for minor memory savings, and even those savings
are questionable. It would have been much easier and simpler to just
add a two-element regulator_dev array to struct max5970_regulator
and live with the "lost" memory if only one of them is used. I suspect
that would have consumed less memory and code overall.

Guenter