Re: [PATCH 3/3 net] dmaengine: ti: k3-udma-glue: clean up k3_udma_glue_tx_get_irq() return

From: Roger Quadros
Date: Tue Sep 26 2023 - 14:46:46 EST




On 26/09/2023 17:06, Dan Carpenter wrote:
> The k3_udma_glue_tx_get_irq() function currently returns negative error
> codes on error, zero on error and positive values for success. This
> complicates life for the callers who need to propagate the error code.
> Also GCC will not warn about unsigned comparisons when you check:
>
> if (unsigned_irq <= 0)
>
> All the callers have been fixed now but let's just make this easy going
> forward.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>