Re: [PATCH v1 1/1] pinctrl: intel: Simplify code with cleanup helpers

[Linus Walleij]

On Tue, Sep 26, 2023 at 3:23 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Use macros defined in linux/cleanup.h to automate resource lifetime
> control in the driver.
>
> While at it, unify the variables and approach in intel_gpio_irq_*().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Actually this is the best part:

>  drivers/pinctrl/intel/pinctrl-intel.c | 136 ++++++++++----------------
>  1 file changed, 50 insertions(+), 86 deletions(-)

So much easier to read the code, and lesser risk to do mistakes.

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij