Re: [PATCH 3/3] hwmon: (pmbus/mpq2286) Add a support for mpq2286 Power Management IC

[Saravanan Sekar]

On 11/09/23 09:53, Guenter Roeck wrote:
> On 9/10/23 20:41, Saravanan Sekar wrote:
> > The MPQ2286 is a programmable, high frequency synchronous buck regulator
> > designed to power a variety of Automotive system peripherals. Single buck
> > converters with hardware monitoring capability is configurable over PMBus
> > interface.
> >
> > Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>
> > ---
> >   drivers/hwmon/pmbus/mpq7932.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/hwmon/pmbus/mpq7932.c 
> > b/drivers/hwmon/pmbus/mpq7932.c
> > index af3e5e9590c8..3ffeece28e2d 100644
> > --- a/drivers/hwmon/pmbus/mpq7932.c
> > +++ b/drivers/hwmon/pmbus/mpq7932.c
> > @@ -21,6 +21,7 @@
> >   #define MPQ7932_N_VOLTAGES        256
> >   #define MPQ7932_VOUT_MAX        0xFF
> >   #define MPQ7932_NUM_PAGES        6
> > +#define MPQ2286_NUM_PAGES        1
> >   #define MPQ7932_TON_DELAY        0x60
> >   #define MPQ7932_VOUT_STARTUP_SLEW    0xA3
> > @@ -130,12 +131,14 @@ static int mpq7932_probe(struct i2c_client *client)
> >   static const struct of_device_id mpq7932_of_match[] = {
> >       { .compatible = "mps,mpq7932", .data = (void *)MPQ7932_NUM_PAGES },
> > +    { .compatible = "mps,mpq2286", .data = (void *)MPQ2286_NUM_PAGES },
> >       {},
> >   };
> >   MODULE_DEVICE_TABLE(of, mpq7932_of_match);
> >   static const struct i2c_device_id mpq7932_id[] = {
> >       { "mpq7932", },
> > +    { "mpq2286", },
>
> Please keep alphabetic order.

agree, will change in v2

> >       { },
> >   };
> >   MODULE_DEVICE_TABLE(i2c, mpq7932_id);
>
> This is one of those super-secret automotive chips where almost no 
> information
> is available to the public. I'll need authoritative confirmation that 
> all the
> various parameters (b. m, output voltage format, minimum and maximum output
> voltage, step size) match mpq7932 exactly. That is rarely the case, so 
> consider
> me skeptic.

Thanks for your time for review. yes, datasheet is not available in 
public but Monolithic shall share on request. I confirm all the 
parameters are match with mpq7932 datasheet and I have tested the device.

> Guenter

Thanks,
Saravanan